Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dep #332

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Use dep #332

merged 1 commit into from
Dec 7, 2017

Conversation

arbourd
Copy link
Contributor

@arbourd arbourd commented Dec 7, 2017 •
edited
Loading

Switch to golang/dep

Some between dep and glide:

  • Cannot ignore golang.org/x/sys/unix (build fails as it doesn't import)
  • dep vendors all dependencies when running dep ensure (for the time being) -- use dep prune to clean up unused dependencies
  • unix builds are using dep at master -- i can download the binary in the Makefile instead

Closes #300

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AppVeyorBot
Copy link

❌ Build torus-cli 383 failed (commit c4afffd46c by @arbourd)

@AppVeyorBot
Copy link

✅ Build torus-cli 386 completed (commit a1c544f6c1 by @arbourd)

@arbourd arbourd changed the title [WIP] Use dep Use dep Dec 7, 2017
@ianlivingstone
Copy link
Contributor

This is awesome, thanks so much for the contribution!

@ianlivingstone ianlivingstone merged commit 74c95ca into manifoldco:master Dec 7, 2017
@arbourd arbourd deleted the use-dep branch December 7, 2017 18:33
@arbourd
Copy link
Contributor Author

arbourd commented Dec 7, 2017 •
edited
Loading

My pleasure. 🤓

Just a quick note: go list ./... | grep -v ./vendor shouldn't be needed with Go 1.9+ which automatically ignores the vendor folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianlivingstone ianlivingstone ianlivingstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arbourd @CLAassistant @AppVeyorBot @ianlivingstone